JACK: Fail AudioIODevice::open() if the client can't be activated - #1702
Open
emezeske wants to merge 1 commit into
Open
JACK: Fail AudioIODevice::open() if the client can't be activated#1702emezeske wants to merge 1 commit into
emezeske wants to merge 1 commit into
Conversation
emezeske
marked this pull request as ready for review
August 10, 2026 20:09
Collaborator
|
This pull request has been mentioned on The JUCE Forum. There might be relevant details there: https://forum.juce.com/t/pr-jack-fail-audioiodevice-open-if-the-client-cant-be-activated/69279/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application can end up completely silent, with a device that reports itself open and running but never invokes its audio callback, and no error surfaced anywhere. With pipewire-jack this happens in practice by changing the enabled channels in AudioDeviceSelectorComponent, whose rapid deactivate/activate cycle pipewire-jack can refuse.
The cause is that JackAudioIODevice::open() calls jack_activate() and ignores its return value, so a failed activation still reports success and marks the device open.
With this change open() fails with an error when jack_activate() returns nonzero, so AudioDeviceManager tears the device down and reports the error instead of silently keeping a dead device.